initial cleanup #11542

ordian · 2020-03-04T15:32:03Z

This is a cleanup PR after #11346, #11528 and #11525.
Note, that the binary name remains the same.

dvdplm

This is hard to review, lots of scrolling. Is there anything here you want us to taker a look at other than s/Parity Ethereum/Open Ethereum/?

util/network/src/client_version.rs

ordian · 2020-03-04T16:16:23Z

util/version/src/lib.rs

@@ -63,7 +63,7 @@ pub fn version_data() -> Bytes {
 		(env!("CARGO_PKG_VERSION_MINOR").parse::<u32>().expect("Environment variables are known to be valid; qed") << 8) +
 		env!("CARGO_PKG_VERSION_PATCH").parse::<u32>().expect("Environment variables are known to be valid; qed");
 	s.append(&v);
-	s.append(&"Parity-Ethereum");
+	s.append(&"Open-Ethereum");


and here as well

I wonder if there are implications of doing this outside the code itself, I'm thinking of things like trackers and whatnot? /cc @joshua-mir ?

https://ethernodes.org/ perhaps, although I don't know how they identify clients

ordian · 2020-03-04T16:17:46Z

rpc/src/v1/helpers/errors.rs

-		data: Some(Value::String(format!("{:?}", error))),
-	}
-}
-


removed unused method

ordian · 2020-03-04T16:20:49Z

This is hard to review, lots of scrolling. Is there anything here you want us to taker a look at other than s/Parity Ethereum/Open Ethereum/?

Sorry I should've split the change to licenses to a separate PR, added some comments to PR.

ordian · 2020-03-04T17:04:19Z

Extracted license change to #11543

evmbin/README.md

ordian · 2020-03-04T17:10:33Z

README.md

@@ -57,7 +56,7 @@ We recommend installing Rust through [rustup](https://www.rustup.rs/). If you do
  $ curl https://sh.rustup.rs -sSf | sh
  ```

-  Parity Ethereum also requires `gcc`, `g++`, `pkg-config`, `file`, `make`, and `cmake` packages to be installed.
+  Open Ethereum also requires `clang`, `clang++`, `pkg-config`, `file`, `make`, and `cmake` packages to be installed.


we've switched to clang sometime ago

We could even state, that OpenEthereum requires clang 9. We had some people that had problems with earlier versions when building rocksdb for instance.

dvdplm · 2020-03-04T17:58:03Z

I think the test failure is legit, there seems to be an expected test payload with ParityClient.

niklasad1 · 2020-03-05T15:44:34Z

.github/CONTRIBUTING.md

@@ -39,7 +39,7 @@ There are a few basic ground-rules for contributors (including the maintainer(s)



Replace Parity Ethereum Style Guide?

I've left it out of scope of this PR, because it points to wiki website that we won't change. Open Ethereum doesn't have a website for now, so all the wiki links will need to be changed sometime later.

Ok, I see. After this PR merged we could maybe add an issue for it because it's easily forgotten. Also, external contributors seem to like fixing documentation :)

Yep, definitely. That's why this PR is called "initial cleanup", I'm not fixing everything here :)

niklasad1 · 2020-03-05T15:51:15Z

README.md


 1. Copy `./scripts/parity.service` to your
 `systemd` user directory (usually `~/.config/systemd/user`).
 2. Copy release to bin folder, write `sudo install ./target/release/parity /usr/bin/parity`
-3. To configure Parity Ethereum, write a `/etc/parity/config.toml` config file, see [Configuring Parity Ethereum](https://paritytech.github.io/wiki/Configuring-Parity) for details.
+3. To configure Open Ethereum, write a `/etc/parity/config.toml` config file, see [Configuring Parity Ethereum](https://paritytech.github.io/wiki/Configuring-Parity) for details.


I guess we will eventually move that documentation to OpenEthereum, maybe say old configuration or something until then

niklasad1 · 2020-03-05T16:02:45Z

And we ignore earlier versions in the changelogs?

See dump from grep below:

docs/CHANGELOG-2.0.md:Note: Parity Ethereum 2.0 reached End-of-Life on 2018-11-15 (EOL).
docs/CHANGELOG-2.0.md:- With this release, all versions of Parity Ethereum 1.x prior to 2.0 reached end of life.
docs/CHANGELOG-2.0.md:- Parity Ethereum 2.0.0 ([#9052](https://github.com/OpenEthereum/open-ethereum/pull/9052))
docs/CHANGELOG-2.1.md:Note: Parity Ethereum 2.1 reached End-of-Life on 2019-01-16 (EOL).
docs/CHANGELOG-2.1.md:- With this release, all versions of Parity Ethereum 1.x prior to 2.0 reached end of life.
docs/CHANGELOG-2.2.md:Note: Parity Ethereum 2.2 reached End-of-Life on 2019-02-25 (EOL).
docs/CHANGELOG-2.2.md:Parity-Ethereum 2.2.10-stable is a security-relevant release. A bug in the JSONRPC-deserialization module can cause crashes of all versions of Parity Ethereum nodes if an attacker is able to submit a specially-crafted RPC to certain publicly available endpoints.
docs/CHANGELOG-2.2.md:Parity-Ethereum 2.2.9-stable is a security-relevant release. A bug in the JSONRPC-deserialization module can cause crashes of all versions of Parity Ethereum nodes if an attacker is able to submit a specially-crafted RPC to certain publicly available endpoints.
docs/CHANGELOG-2.2.md:  - Autogen docs for the "Configuring Parity Ethereum" wiki page. ([#10067](https://github.com/OpenEthereum/open-ethereum/pull/10067))
docs/CHANGELOG-2.2.md:Before upgrading to 2.2.2, please also verify the validity of your chain specs. Parity Ethereum now denies unknown fields in the specification. To do this, use the chainspec tool:
docs/CHANGELOG-2.2.md:- Prevent zero network ID ([#9763](https://github.com/OpenEthereum/open-ethereum/pull/9763)) and drop support for Olympic testnet ([#9801](https://github.com/OpenEthereum/open-ethereum/pull/9801)): The Olympic test net is dead for years and never used a chain ID but network ID zero. Parity Ethereum is now preventing the network ID to be zero, thus Olympic support is dropped. Make sure to chose positive non-zero network IDs in future.
docs/CHANGELOG-2.2.md:- Expose config max-round-blocks-to-import ([#9439](https://github.com/OpenEthereum/open-ethereum/pull/9439)): Parity Ethereum imports blocks in rounds. If at the end of any round, the queue is not empty, we consider it to be _importing_ and won't notify pubsub. On large re-orgs (10+ blocks), this is possible. The default `max_round_blocks_to_import` is increased to 12 and configurable via the `--max-round-blocks-to-import` CLI flag. With unstable network conditions, it is advised to increase the number. This shouldn't have any noticeable performance impact unless the number is set to really large.
docs/CHANGELOG-2.2.md:- Produce portable binaries ([#9725](https://github.com/OpenEthereum/open-ethereum/pull/9725)): we now produce portable binaries, but it may incur some performance degradation. For ultimate performance it's now better to compile Parity Ethereum from source with `PORTABLE=OFF` environment variable.
docs/CHANGELOG-2.3.md:Parity-Ethereum 2.3.3-beta is a security-relevant release. A bug in the JSONRPC-deserialization module can cause crashes of all versions of Parity Ethereum nodes if an attacker is able to submit a specially-crafted RPC to certain publicly available endpoints.
docs/CHANGELOG-2.3.md:Parity-Ethereum 2.3.2-stable is a security-relevant release. A bug in the JSONRPC-deserialization module can cause crashes of all versions of Parity Ethereum nodes if an attacker is able to submit a specially-crafted RPC to certain publicly available endpoints.
docs/CHANGELOG-2.3.md:- The Tendermint engine was removed from Parity Ethereum and is no longer available and maintained. ([#9980](https://github.com/OpenEthereum/open-ethereum/pull/9980))
docs/CHANGELOG-2.3.md:- Autogen docs for the "Configuring Parity Ethereum" wiki page. ([#10067](https://github.com/OpenEthereum/open-ethereum/pull/10067))
docs/CHANGELOG-2.4.md:Parity Ethereum v2.4.9-stable is a security update which addresses servo/rust-smallvec#148
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.13-stable is a security release. Valid blocks with manipulated transactions (added/replaced) cause the client to stall.
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.12-stable is a patch release that adds Istanbul hardfork
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.11-stable is an emergency patch release that adds the missing
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.10-stable is a patch release that adds block numbers for
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.9-stable is a patch release that adds the block numbers for activating the Istanbul hardfork on test networks: Ropsten, Görli, Rinkeby and Kovan.
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.8-stable is a patch release that improves security, stability and performance.
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.7-stable is a bugfix release that fixes a potential DoS attack in the trace_call RPC method. This is a critical upgrade for anyone running Parity nodes with RPC exposed to the public internet (and highly recommended for anyone else). For details see this blog post.
docs/CHANGELOG-2.5.md:Parity Ethereum v2.5.4-beta is a security update that addresses servo/rust-smallvec#148
docs/CHANGELOG-2.6.md:Parity Ethereum v2.6.8-beta is a security release. Valid blocks with manipulated transactions (added/replaced) cause the client to stall.
docs/CHANGELOG-2.6.md:Parity Ethereum v2.6.7-beta is a patch release that adds Istanbul hardfork
docs/CHANGELOG-2.6.md:Parity Ethereum v2.6.6-beta is an emergency patch release that adds the missing
docs/CHANGELOG-2.6.md:Parity Ethereum v2.6.5-beta is a patch release that adds block numbers for activating the Istanbul hardfork on mainnet, as well as a large number of various bugfixes, QoL changes, some code cleanup/refactoring and other miscellaneous changes.
docs/CHANGELOG-2.6.md:Parity Ethereum v2.6.4-stable is a patch release that adds the block numbers for activating the Istanbul hardfork on test networks: Ropsten, Görli, Rinkeby and Kovan.
docs/CHANGELOG-2.6.md:Parity Ethereum v2.6.3-stable is a patch release that improves security, stability and performance.
docs/CHANGELOG-2.6.md:Parity Ethereum v2.6.2-stable is a bugfix release that fixes a potential DoS attack in the trace_call RPC method. This is a critical upgrade for anyone running Parity nodes with RPC exposed to the public internet (and highly recommended for anyone else). For details see this blog post.

niklasad1

Good job! Looks ok to me

ordian · 2020-03-05T16:08:58Z

And we ignore earlier versions in the changelogs?

The client was called Parity before 2.0 and you can see it's called Parity in changelog 1.10 (not sure why we renamed it in 1.11). Since the name will only change from now on, I think it's logical to keep the previous name in the changelogs for the history.

* master: Code cleanup in the sync module (#11552) initial cleanup (#11542) Warn if genesis constructor revert (#11550) ethcore: cleanup after #11531 (#11546) license update (#11543) Less cloning when importing blocks (#11531) Github Actions (#11528) Fix Alpine Dockerfile (#11538) Remove AuxiliaryData/AuxiliaryRequest (#11533) [journaldb]: cleanup (#11534) Remove references to parity-ethereum (#11525) Drop IPFS support (#11532) chain-supplier: fix warning reporting for GetNodeData request (#11530) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524)

* master: informant: display I/O stats (#11523) [devp2p discovery]: remove `deprecated_echo_hash` (#11564) [secretstore] create db_version file when database doesn't exist (#11570) Remove Parity's Security Policy (#11565) ethcore/res: enable ecip-1088 phoenix upgrade for kotti and mordor testnets (#11529) Misc docs and renames …and one less clone (#11556) [secretstore]: don't sign message with only zeroes (#11561) [devp2p discovery]: cleanup (#11547) Code cleanup in the sync module (#11552) initial cleanup (#11542) Warn if genesis constructor revert (#11550)

dvdplm reviewed Mar 4, 2020

View reviewed changes

ordian commented Mar 4, 2020

View reviewed changes

util/network/src/client_version.rs Outdated Show resolved Hide resolved

ordian commented Mar 4, 2020

View reviewed changes

ordian mentioned this pull request Mar 4, 2020

license update #11543

Merged

cleanup

bbbe494

ordian force-pushed the ao-cleanup branch from 3671ae8 to bbbe494 Compare March 4, 2020 17:03

ordian commented Mar 4, 2020

View reviewed changes

evmbin/README.md Outdated Show resolved Hide resolved

ordian commented Mar 4, 2020

View reviewed changes

ordian added 2 commits March 4, 2020 18:13

upbork

e9c8803

review grumble: rename client id prefix

b1120f1

ordian added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Mar 4, 2020

ordian added 2 commits March 4, 2020 20:32

rpc-tests: make one of the clients open-ethereum

81e8f42

fix doctest

d13ce00

niklasad1 reviewed Mar 5, 2020

View reviewed changes

niklasad1 approved these changes Mar 5, 2020

View reviewed changes

niklasad1 requested a review from vorot93 March 5, 2020 16:08

README: mention clang version and that our wiki is old

98bfd7a

dvdplm approved these changes Mar 9, 2020

View reviewed changes

dvdplm merged commit 10d82ef into master Mar 9, 2020

dvdplm deleted the ao-cleanup branch March 9, 2020 14:07

ordian mentioned this pull request Mar 9, 2020

Update links pointing to wiki.parity.io #11553

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial cleanup #11542

initial cleanup #11542

ordian commented Mar 4, 2020

dvdplm left a comment

ordian Mar 4, 2020

dvdplm Mar 4, 2020

ordian Mar 4, 2020

ordian Mar 4, 2020

ordian commented Mar 4, 2020

ordian commented Mar 4, 2020

ordian Mar 4, 2020

niklasad1 Mar 5, 2020 •

edited

Loading

dvdplm commented Mar 4, 2020 •

edited

Loading

niklasad1 Mar 5, 2020

ordian Mar 5, 2020 •

edited

Loading

niklasad1 Mar 5, 2020

ordian Mar 5, 2020

niklasad1 Mar 5, 2020

niklasad1 commented Mar 5, 2020

niklasad1 left a comment

ordian commented Mar 5, 2020 •

edited

Loading

		@@ -39,7 +39,7 @@ There are a few basic ground-rules for contributors (including the maintainer(s)

initial cleanup #11542

initial cleanup #11542

Conversation

ordian commented Mar 4, 2020

dvdplm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ordian commented Mar 4, 2020

ordian commented Mar 4, 2020

Choose a reason for hiding this comment

niklasad1 Mar 5, 2020 • edited Loading

Choose a reason for hiding this comment

dvdplm commented Mar 4, 2020 • edited Loading

Choose a reason for hiding this comment

ordian Mar 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niklasad1 commented Mar 5, 2020

niklasad1 left a comment

Choose a reason for hiding this comment

ordian commented Mar 5, 2020 • edited Loading

niklasad1 Mar 5, 2020 •

edited

Loading

dvdplm commented Mar 4, 2020 •

edited

Loading

ordian Mar 5, 2020 •

edited

Loading

ordian commented Mar 5, 2020 •

edited

Loading