Fixpetrarch2 #5
Merged
Fixpetrarch2 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, moved petrarch 2 parse format fixer into hypnos app.py
Example taken from Petrarch 2 unit tests. The old example does not produce an event in Petrarch 2.
|
Wow, great work @benradford. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed hypnos such that it builds and works despite underlying formatting issues in petrarch2. Neither the petrarch2 or corenlp sub-containers are modified.
Hypnos with Petrarch2 was breaking (see #4 (comment)). This was due, in part, to the following remediated errors:
json.dumpsto fail._format_parsed_strwasn't being called prior todo_coding.Hypnos docker should now build properly and the example code works properly. I changed the example in the readme because Petrarch2 was not identifying events in the previous example. However, the examples given in the Petrarch2 unit tests work as expected.
The output format is slightly modified to correct for Petrarch2's poorly formatted output, but I anticipate that it will be backwards compatible with the previous output format for all (at least most) applications.