Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue #4 and #5 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for issue #4 and #5 #6

wants to merge 1 commit into from

Conversation

tmiklas
Copy link

@tmiklas tmiklas commented May 17, 2019

Fixed issue #4 (cpanfile ignored at build) and #5 (possible name collision due to module load order).

Signed-off-by: Tomasz Miklas [email protected]

…ision due to module load order)

Signed-off-by: Tomasz Miklas <[email protected]>
@zeerorg
Copy link
Contributor

zeerorg commented May 19, 2019

This looks good to me. I'll try to test these changes locally and then approve this PR.

Copy link
Contributor

@zeerorg zeerorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR. LGTM

Copy link
Contributor

@zeerorg zeerorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants