Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arkade already creating namespace of argocd we don't need additional …step, the line for getting secret is wrapped to be able to show it in browser #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

developer-guy
Copy link
Contributor

Signed-off-by: Batuhan Apaydın [email protected]

Description

arkade is already creating namespace of ArgoCD we don't need additional …step, the line for getting secret is wrapped to be able to show it in browser

Motivation and Context

Have you applied the editorial and style guide to your post?

See the README.md

How have you tested the instructions for any tutorial steps?

Types of changes

  • New blog post
  • Updating an existing blog post
  • Updating part of the page page
  • Adding a new web-page

Checklist:

  • I have given attribution for any images I have used and have permission to use them under Copyright law
  • My code follows the writing-style of the publication and I have checked this
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@alexellis
Copy link
Member

Thanks for the PR. Pinging @Waterdrips for review/comment.

@alexellis alexellis removed the request for review from Waterdrips May 14, 2021 17:31
@alexellis
Copy link
Member

My mistake - we don't need Alistair for this PR. Please see my note.

@developer-guy
Copy link
Contributor Author

done @alexellis 👍

…step, the line for getting secret is wrapped to be able to show it in browser

Signed-off-by: Batuhan Apaydın <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants