Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added F# template to templates.json #65

Closed
wants to merge 20 commits into from
Closed

Added F# template to templates.json #65

wants to merge 20 commits into from

Conversation

hayer
Copy link

@hayer hayer commented Mar 6, 2019

Added my F# template to the templates.json list, #64.

@derek derek bot added the new-contributor label Mar 6, 2019
@derek derek bot added the no-dco label Apr 9, 2019
@derek
Copy link

derek bot commented Apr 9, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --sign-off and then git push --force.

@hayer
Copy link
Author

hayer commented Apr 17, 2019

@alexellis think I got the sign-off right. Checks passed. Merge OK?

@alexellis
Copy link
Member

Please reset the commits and apply a single commit, thanks.

Signed-off-by: Peder Husom <[email protected]>
@derek derek bot removed the no-dco label Apr 23, 2019
@hayer
Copy link
Author

hayer commented Apr 27, 2019

@alexellis all done?

rgee0 and others added 19 commits June 4, 2019 00:40
The new function.json was not being checked for valid json, nor were the images
contained within the json being checked for existence.

This change adds two lines to the CI.  One to parse the json in the same way as
the existing json files are parsed.  And a second line that calls a bash script
which calls against Docker Hub to ensure that the image exists.  Rather than
pulling each image the script makes a curl request agaisnt the API and errors out
if a HTTP200 isnt received.

Signed-off-by: Richard Gee <[email protected]>
Signed-off-by: Alex Ellis <[email protected]>
For new watchdog 0.13.0 and new http probe

Signed-off-by: Alex Ellis <[email protected]>
Signed-off-by: Alex Ellis <[email protected]>
Signed-off-by: Alex Ellis <[email protected]>
Signed-off-by: Alex Ellis <[email protected]>
Moving function definitions from integers to golang duration

Signed-off-by: Martin Dekov <[email protected]>
Signed-off-by: Daniel Llewellyn <[email protected]>
Signed-off-by: Peder Husom <[email protected]>
@derek derek bot added the no-dco label Jun 3, 2019
@derek
Copy link

derek bot commented Jun 3, 2019

Thank you for your contribution. It seems that one or more of your commits have an anonymous email address. Please consider signing your commits with a valid email address. Please see our contributing guide.

@alexellis
Copy link
Member

Screenshot 2019-06-04 at 19 32 56

git can be tricky at times. Perhaps it would be easier for you to raise a new PR and close this one?

--
Join Slack to connect with the community
https://docs.openfaas.com

@hayer
Copy link
Author

hayer commented Jun 4, 2019

Yea, sorry. Was in a hurry, went a little to fast there.

@hayer hayer closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants