Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting contextual tuples in assertions API (#157) #167

Merged
merged 3 commits into from
May 29, 2024
Merged

Reverting contextual tuples in assertions API (#157) #167

merged 3 commits into from
May 29, 2024

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented May 29, 2024 •
edited
Loading

Description

Reverts #157 which added contextual tuples in the assertions API. This is being removed because the new API still needs new work and should not be included in the upcoming v1.5.4 release of OpenFGA. The implementation of #157 in OpenFGA was also reverted: openfga/openfga#1646.

This will be re-introduced in the https://github.com/openfga/api/tree/feat/contextual-tuples branch.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@willvedd willvedd requested review from a team as code owners May 29, 2024 18:40
@jon-whit jon-whit merged commit 5b0b494 into main May 29, 2024
6 of 7 checks passed
@jon-whit jon-whit deleted the reverting-contextual-tuples-in-assertions branch May 29, 2024 18:44
@jon-whit jon-whit mentioned this pull request May 29, 2024
Merged
4 tasks
miparnisari added a commit that referenced this pull request Aug 6, 2024
@miparnisari
Revert "Reverting contextual tuples in assertions API (#157) (#167)"
d53ea84 
This reverts commit 5b0b494.
miparnisari added a commit that referenced this pull request Aug 7, 2024
@miparnisari
feat: add support for contextual tuples in assertions API (#185)
c96ec77 
* Revert "Reverting contextual tuples in assertions API (#157) (#167)"

This reverts commit 5b0b494.

* undo go.mod changes

* amend API descriptions

* run make

* apply suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-whit jon-whit jon-whit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willvedd @jon-whit