fix(model): exit with error when any model test fails

cmd/model/test.go

@@ -20,7 +20,6 @@ import (
 	"fmt"
 	"os"
 	"path"
-	"strings"
 
 	"github.com/openfga/cli/internal/cmdutils"
 	"github.com/openfga/cli/internal/output"
@@ -66,7 +65,7 @@ var testCmd = &cobra.Command{
 			return err //nolint:wrapcheck
 		}
 
-		results, err := storetest.RunTests(
+		test, err := storetest.RunTests(
 			fgaClient,
 			storeData,
 			path.Dir(testsFileName),
@@ -75,18 +74,25 @@ var testCmd = &cobra.Command{
 			return fmt.Errorf("error running tests due to %w", err)
 		}
 
+		passing := test.IsPassing()
+
 		if verbose {
-			return output.Display(results) //nolint:wrapcheck
+			err = output.Display(test.Results)
+			if err != nil {
+				return fmt.Errorf("error displaying test results due to %w", err)
+			}
+
+			if !passing {
+				os.Exit(1)
+			}
 		}
 
-		friendlyResults := []string{}
+		fmt.Println(test.FriendlyDisplay())
 
-		for index := 0; index < len(results); index++ {
-			friendlyResults = append(friendlyResults, results[index].FriendlyDisplay())
+		if !passing {
+			os.Exit(1)
 		}
 
-		fmt.Printf("%v", strings.Join(friendlyResults, "\n---\n"))
-
 		return nil
 	},
 }

internal/storetest/testresult.go

@@ -2,6 +2,7 @@ package storetest
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/openfga/cli/internal/comparison"
 	"github.com/openfga/go-sdk/client"
@@ -38,6 +39,23 @@ type TestResult struct {
 	ListObjectsResults []ModelTestListObjectsSingleResult `json:"list_objects_results"`
 }
 
+// IsPassing - indicates whether a Test has succeeded completely or has any failing parts.
+func (result TestResult) IsPassing() bool {
+	for index := 0; index < len(result.CheckResults); index++ {
+		if !result.CheckResults[index].IsPassing() {
+			return false
+		}
+	}
+
+	for index := 0; index < len(result.ListObjectsResults); index++ {
+		if !result.ListObjectsResults[index].IsPassing() {
+			return false
+		}
+	}
+
+	return true
+}
+
 //nolint:cyclop
 func (result TestResult) FriendlyDisplay() string {
 	totalCheckCount := len(result.CheckResults)
@@ -51,7 +69,7 @@ func (result TestResult) FriendlyDisplay() string {
 		for index := 0; index < totalCheckCount; index++ {
 			checkResult := result.CheckResults[index]
 
-			if result.CheckResults[index].IsPassing() {
+			if checkResult.IsPassing() {
 				checkResultsOutput = fmt.Sprintf(
 					"%s\n✓ Check(user=%s,relation=%s,object=%s)",
 					checkResultsOutput,
@@ -85,7 +103,7 @@ func (result TestResult) FriendlyDisplay() string {
 		for index := 0; index < totalListObjectsCount; index++ {
 			listObjectsResult := result.ListObjectsResults[index]
 
-			if result.ListObjectsResults[index].IsPassing() {
+			if listObjectsResult.IsPassing() {
 				listObjectsResultsOutput = fmt.Sprintf(
 					"%s\n✓ ListObjects(user=%s,relation=%s,type=%s)",
 					listObjectsResultsOutput,
@@ -140,3 +158,28 @@ func (result TestResult) FriendlyDisplay() string {
 
 	return output
 }
+
+type TestResults struct {
+	Results []TestResult `json:"results"`
+}
+
+// IsPassing - indicates whether a Test Suite has succeeded completely or has any failing tests.
+func (test TestResults) IsPassing() bool {
+	for index := 0; index < len(test.Results); index++ {
+		if !test.Results[index].IsPassing() {
+			return false
+		}
+	}
+
+	return true
+}
+
+func (test TestResults) FriendlyDisplay() string {
+	friendlyResults := []string{}
+
+	for index := 0; index < len(test.Results); index++ {
+		friendlyResults = append(friendlyResults, test.Results[index].FriendlyDisplay())
+	}
+
+	return fmt.Sprintf("%v", strings.Join(friendlyResults, "\n---\n"))
+}

internal/storetest/tests.go

@@ -32,12 +32,12 @@ func RunTests(
 	fgaClient *client.OpenFgaClient,
 	storeData StoreData,
 	basePath string,
-) ([]TestResult, error) {
-	results := []TestResult{}
+) (TestResults, error) {
+	test := TestResults{}
 
 	fgaServer, authModel, err := getLocalServerAndModel(storeData, basePath)
 	if err != nil {
-		return results, err
+		return test, err
 	}
 
 	for index := 0; index < len(storeData.Tests); index++ {
@@ -49,11 +49,11 @@ func RunTests(
 			authModel,
 		)
 		if err != nil {
-			return results, err
+			return test, err
 		}
 
-		results = append(results, result)
+		test.Results = append(test.Results, result)
 	}
 
-	return results, nil
+	return test, nil
 }