-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support csv in tuple delete #260
base: main
Are you sure you want to change the base?
Conversation
|
@kindlyturnips Hi! Could you please sign the EasyCLA, so we can approve/merge? Thanks! |
Hi @aaguiarz |
Hi @kindlyturnips - in order to fix the EasyCLA issue, can I ask you to squash your commits into 1? You can do It would also be great if you can edit your commit message to follow conventional commit format, e.g. |
690d237
to
7e724b5
Compare
Hi @rhamzeh, Thanks for the corrections, I've made the suggested changes. Please let me know if there is anything else, and again thank you for your patience. This is my first open source contribution and I'm learning alot :) |
Thanks @kindlyturnips! For a first OSS contribution this is great! Kudos! We're so happy you chose OpenFGA for that milestone, and hopefully this will lead you to much more contributions to this project and others ❤️ Some minor feedback to unblock this PR:
|
… into delete_tuple_csv
Hi @rhamzeh, |
👋 hello there! Thanks for putting this PR together. I'm also interested in CSV support in the delete command. Any plans to resurrect this work? |
Description
Added functionality to delete tuples from .csv files.
References
Review Checklist
main