Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing excluded users from ListUsers response #347

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jun 13, 2024

Description

Removes excluded_users from ListUsers response as it was removed from OpenFGA with openfga/api#171 and openfga/sdk-generator#377.

This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g. user:) as a means of being abundantly clear about what a user: result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-add excluded_users at some point in the future but may or may not be a flattened list as previously implemented.

This was tested with a locally-generated version of the Go SDK.

Please note:

  • This is a draft until the Go SDK is rebuilt
  • This is technically a breaking but is acceptable provided that the ListUsers API is still experimental

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@willvedd willvedd requested review from a team as code owners June 13, 2024 13:41
@willvedd willvedd marked this pull request as draft June 13, 2024 13:41
@willvedd willvedd marked this pull request as ready for review June 14, 2024 15:37
go.mod Show resolved Hide resolved
rhamzeh
rhamzeh previously approved these changes Jun 15, 2024
@willvedd willvedd added this pull request to the merge queue Jun 17, 2024
@ewanharris ewanharris removed this pull request from the merge queue due to a manual request Jun 17, 2024
@willvedd willvedd added this pull request to the merge queue Jun 17, 2024
@willvedd willvedd removed this pull request from the merge queue due to a manual request Jun 17, 2024
@ewanharris ewanharris force-pushed the list-users-remove-excluded-users branch from f40c4ae to c1c3455 Compare June 17, 2024 12:26
@ewanharris ewanharris enabled auto-merge June 17, 2024 12:26
@ewanharris ewanharris added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit c8e464f Jun 17, 2024
17 checks passed
@ewanharris ewanharris deleted the list-users-remove-excluded-users branch June 17, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants