Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix lint warnings #382

Merged
merged 1 commit into from
Aug 31, 2024
Merged

refactor: fix lint warnings #382

merged 1 commit into from
Aug 31, 2024

Conversation

ewanharris
Copy link
Member

Description

New version of golangci-lint, new failures. Rather than silence them I tried to approach solving them properly by making use of ulid.Time or correctly typing things.

References

See failures here

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner August 30, 2024 11:12
@rhamzeh rhamzeh added this pull request to the merge queue Aug 31, 2024
Merged via the queue into main with commit 4d3ce53 Aug 31, 2024
17 checks passed
@rhamzeh rhamzeh deleted the refactor/fix-lint-errors branch August 31, 2024 03:28
@ewanharris ewanharris mentioned this pull request Sep 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewanharris @rhamzeh