feat: add note cache is no longer experimental #547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-whit
reviewed
Nov 7, 2023
jon-whit
reviewed
Nov 7, 2023
| |-------------------|--------------------------------------------------------------------|-----------------------|-------------------------------| | ||
| | otel-metrics | Enables support for exposing OpenFGA metrics through OpenTelemetry | `0.3.2 <= v < v0.3.5` | became default in `v0.3.5` | | ||
| | list-objects | Enables ListObjects API | `0.2.0 <= v < v0.3.3` | became default in `v0.3.3` | | ||
| | check-query-cache | Enables caching of check subproblem result | `1.3.1 <= v < v1.3.6` | became supported from `v1.3.6`| |
There was a problem hiding this comment.
Here and above, I'm not sure what this is supposed to mean. I wonder if we can drop the "Status" column in favor of just the explicit version range?
An experimental flag is present in a release until we remove it. Once we remove it I wouldn't say it is "defaulted", because it is is gone. It no longer is interpreted in any way by the server. So I think it is less confusing if we just say the range of OpenFGA server versions that the experimental flag existed in.
WDYT?
There was a problem hiding this comment.
Agree - I have trouble coming up with what to write in the status section. What do you think @rhamzeh ?
|
Close in light of #594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache is no longer considered experimental
References
https://github.com/openfga/openfga/releases/tag/v1.3.6
Review Checklist
main