Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the assertion within the 'Get Started with Modeling' page. #568

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Fix the assertion within the 'Get Started with Modeling' page. #568

merged 3 commits into from
Nov 30, 2023

Conversation

brunicius
Copy link
Contributor

Description

This change corrects the assertion that Beth does not have the can_share relationship with document:1, even though she is an editor of it.

image
The relationship definition.

image
Relationship tuples.

image
Old assertion.

image
Fixed assertion.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@brunicius brunicius requested a review from a team as a code owner November 28, 2023 05:23
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 30, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: brunicius / name: Bruno Vinicius (c116132)
  • ✅ login: adriantam / name: Adrian Tam (c33337a, 3f0a838)

@adriantam
Copy link
Member

Thank you @brunicius for your contribution. Can you sign the CLA so that we can take the change? Thank you.

@brunicius
Copy link
Contributor Author

Thank you @brunicius for your contribution. Can you sign the CLA so that we can take the change? Thank you.

You're welcome, I just signed the CLA.

@adriantam adriantam merged commit 1ec4f43 into openfga:main Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunicius @adriantam