Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-sdk): update FGA API doc string in js patch #303

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

ewanharris
Copy link
Member

Description

The Read API docstring changed so we need to reflect that into the JS SDK patchfile in order for the build to work

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner February 6, 2024 12:25
@ewanharris ewanharris changed the title chore(js-sdk): update doc string in js patch chore(js-sdk): update FGA API doc string in js patch Feb 6, 2024
@rhamzeh
Copy link
Member

rhamzeh commented Feb 6, 2024

Thanks @ewanharris - Thankfully this will stop being an issue once we complete #118

@ewanharris ewanharris added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit d9368c8 Feb 6, 2024
13 checks passed
@ewanharris ewanharris deleted the chore/fix-js-patch branch February 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants