Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lifting conditions grammar up to openfga #106

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented Nov 6, 2023

Description

Highlighting CEL as per this textMate grammar

This current grammar expects there only a single set of { } parens for the condition expression.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery requested a review from rhamzeh November 6, 2023 19:29
@d-jeffery d-jeffery marked this pull request as ready for review November 6, 2023 19:29
@d-jeffery d-jeffery requested a review from a team as a code owner November 6, 2023 19:29
@d-jeffery d-jeffery force-pushed the fix/cel-expressions branch from 951fd32 to 918e390 Compare November 6, 2023 19:34
@d-jeffery d-jeffery force-pushed the fix/cel-expressions branch from 918e390 to 1b3579f Compare November 6, 2023 19:38
@rhamzeh rhamzeh added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 1885aca Nov 6, 2023
@rhamzeh rhamzeh deleted the fix/cel-expressions branch November 6, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants