Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: attribute "gradle-plugin" of android config is never read #1858

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

giuppe
Copy link
Contributor

@giuppe giuppe commented Nov 8, 2024

Adding the tag:

<android gradle-plugin="8.7.0" />

to Project.xml has no effect right now, while in AndroidPlatform.hx it is considered valid:

context.ANDROID_GRADLE_PLUGIN = project.config.getString("android.gradle-plugin", "7.3.1");

This is because the ProjectXMLParser is missing the related case - there is one for gradle-version but nothing for gradle-plugin.

@player-03 player-03 merged commit 051f4d5 into openfl:develop Nov 8, 2024
12 checks passed
@giuppe giuppe deleted the patch-1 branch November 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants