Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved nutrition input (part 2) #6270

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 23, 2025

Hi everyone!

After a few days of using #6261, I've changed a few things.
Video:

ScreenRecording_01-23-2025.19-51-44_1.MP4

Nutrition facts

Improved layout

Circled text input + odd/even background colors
IMG_136A506D37EC-2

A new nutrient will be highlighted

IMG_136A506D37EC-3

Slight shadow when scrolling

IMG_136A506D37EC-3

Photo

Revel animation

Pinch to zoom explainer

Same as the ingredient's screen
IMG_1985

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.60643% with 245 lines in your changes missing coverage. Please review.

Project coverage is 6.01%. Comparing base (4d9c7fc) to head (00a1a5e).
Report is 695 commits behind head on develop.

Files with missing lines Patch % Lines
...nutrition_page/widgets/nutrition_facts_editor.dart 0.00% 90 Missing ⚠️
..._app/lib/pages/product/edit_ocr/edit_ocr_page.dart 0.00% 46 Missing ⚠️
...nutrition_page/widgets/nutrition_image_viewer.dart 0.00% 45 Missing ⚠️
...pages/product/helpers/pinch_to_zoom_indicator.dart 4.76% 20 Missing ⚠️
...b/pages/product/nutrition_page/nutrition_page.dart 0.00% 17 Missing ⚠️
...mooth_app/lib/generic_lib/widgets/smooth_card.dart 0.00% 11 Missing ⚠️
...ges/smooth_app/lib/themes/smooth_theme_colors.dart 11.11% 8 Missing ⚠️
...ckages/smooth_app/lib/widgets/smooth_dropdown.dart 0.00% 4 Missing ⚠️
...pp/lib/generic_lib/widgets/smooth_sliver_card.dart 0.00% 3 Missing ⚠️
...trition_page/widgets/nutrition_serving_switch.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6270      +/-   ##
==========================================
- Coverage     9.54%   6.01%   -3.54%     
==========================================
  Files          325     470     +145     
  Lines        16411   27559   +11148     
==========================================
+ Hits          1567    1657      +90     
- Misses       14844   25902   +11058     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 4890b1b into openfoodfacts:develop Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants