Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 6281 LateError: LateInitializationError #6287

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 26, 2025

Fix #6281

@github-actions github-actions bot added 🥫 Product page GitHub 🌐 l10n ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - Nutrition input ✏️ Editing - Basic info input autocomplete labels Jan 26, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.84758% with 425 lines in your changes missing coverage. Please review.

Project coverage is 6.00%. Comparing base (4d9c7fc) to head (34cc774).
Report is 701 commits behind head on develop.

Files with missing lines Patch % Lines
...duct/add_basic_details/add_basic_details_name.dart 0.40% 243 Missing ⚠️
...duct/add_basic_details/add_basic_details_page.dart 0.00% 117 Missing ⚠️
...pages/input/debounced_text_editing_controller.dart 0.00% 25 Missing ⚠️
packages/smooth_app/lib/helpers/paint_helper.dart 0.00% 13 Missing ⚠️
...app/lib/pages/product/edit_ocr/edit_ocr_image.dart 0.00% 10 Missing ⚠️
...ib/pages/input/smooth_autocomplete_text_field.dart 0.00% 5 Missing ⚠️
...p/lib/pages/product/edit_product_image_viewer.dart 0.00% 4 Missing ⚠️
...smooth_app/lib/pages/product/owner_field_info.dart 0.00% 4 Missing ⚠️
...b/pages/product/nutrition_page/nutrition_page.dart 0.00% 2 Missing ⚠️
...mooth_app/lib/generic_lib/widgets/smooth_card.dart 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6287      +/-   ##
==========================================
- Coverage     9.54%   6.00%   -3.55%     
==========================================
  Files          325     471     +146     
  Lines        16411   27712   +11301     
==========================================
+ Hits          1567    1664      +97     
- Misses       14844   26048   +11204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you add some color about the issue solved @g123k ?
  • Are all changes here about this fix (or some PR mixing) ?

@g123k
Copy link
Collaborator Author

g123k commented Jan 26, 2025

In the new OCR screen (= ingredients/packaging edition), the first frame of the animation will have this error when you extract the content = nothing visible.

@teolemon teolemon merged commit 4cef8f0 into openfoodfacts:develop Jan 26, 2025
6 checks passed
@teolemon
Copy link
Member

Thanks for the explanation @g123k 👍

@g123k g123k deleted the issue_6280 branch January 26, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete ✏️ Editing - Basic info input ✏️ Editing - Nutrition input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users GitHub 🌐 l10n 🥫 Product page
Development

Successfully merging this pull request may close these issues.

ArgumentError: RangeError (length): Invalid value: Only valid value is 0: 2
3 participants