Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store raw stopwords and rewrite them at export #358

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

perierc
Copy link
Contributor

@perierc perierc commented Jan 19, 2024

What

Currently, the parser reads the raw stopwords from the input taxonomy file, normalizes them and stores only these normalized stopwords in the Neo4J database.

This PR makes the parser store the raw stopwords also, to be able to rewrite them at export.

WARNING: This PR will make previously open projects impossible to export.

Part of

See issue #357

@perierc perierc requested a review from a team as a code owner January 19, 2024 08:37
@perierc perierc linked an issue Jan 19, 2024 that may be closed by this pull request
@perierc perierc added backend and removed tests labels Jan 19, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this breaks the export for projects parsed before this PR.

@github-actions github-actions bot added tests and removed backend labels Jan 19, 2024
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good !

Just added two comment if you want to integrate them before merging.

@perierc perierc merged commit 444f76d into main Jan 24, 2024
7 checks passed
@perierc perierc deleted the perierc/store-raw-stopwords branch January 24, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Store raw stopwords to rewrite them at export
2 participants