-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): Enhance Edition of Properties for a Node #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me.
Although there are quirk, as we don't get appropriate error messages if the property name is not valid (we provoque a 500 error instead).
See #380 for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for solving the bugs, it's much more usable!
However, I have a style/UX nit: could you make it so the UI does not "jump" when we do edits/save changes? (I think that leaving some vertical space below the table for the "Save changes" button to appear should do it)
If you do not want to do it in this PR (to be fair, the footer vertical blank space should be applied to the App
component), you can just create an issue
What
Screenshot
EditionPropertiesWithoutPR1.mp4
Fixes bug(s)
EditionPropertiesWithPR1.mp4
I've changed the style of the table and removed pagination to help users to edit properties :