chore: Log more expressive errors for missing child links #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alexgarel
approved these changes
Feb 6, 2024
Comment on lines
348
to
358
| for lc, lc_child_links in lc_child_links_map.items(): | ||
| # we collect all the tags_ids in a certain language | ||
| tags_ids = set() | ||
| for node in entry_nodes: | ||
| if "tags_ids_" + lc in node.tags: | ||
| tags_ids.update(node.tags["tags_ids_" + lc]) | ||
|
|
||
| # we check if the parent_id exists in the tags_ids | ||
| for child_link in lc_child_links: | ||
| if child_link["parent_id"] not in tags_ids: | ||
| missing_child_links.append((lc, child_link)) |
There was a problem hiding this comment.
Very good implementation, but it seems of a pity that we do not make the most of this computation.
If, instead of a set, tags_ids is a dict mapping tags_ids to their canonical id, it still can be used to check for existence, but we can also retrieve the real parent at the same cost.
This will simplify (and improve performance on) parent links creation in the graph.
There was a problem hiding this comment.
Yes good idea!
alexgarel
deleted the
ericn/log-more-expressive-errors-for-child-links
branch
eric-nguyen-cs
changed the title
eric-nguyen-cs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)