fix: App bar fixes #392
Merged
fix: App bar fixes #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work, the text is white on beige background @alexgarel |
Comment on lines
127
to
131
| <MuiLink | ||
| sx={{ mr: 2, display: "flex", alignSelf: "center" }} | ||
| href="https://world.openfoodfacts.org/" | ||
| href="https://ui.taxonomy.openfoodfacts.net/" | ||
| target="_blank" | ||
| > |
There was a problem hiding this comment.
This should probably be a react-router-dom Link to the / path (you can look at how it is done below with the Taxonomy Editor text), as the link we want the logo to poin to depends on where the app is deployed
|
@eric-nguyen-cs @alexgarel I made the text black. The routing stuff is currently beyond my feeble React knowledge 😅 |
teolemon
commented
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What