Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): fix create_node function #393

Merged
merged 4 commits into from
Feb 8, 2024
Merged

fix(backend): fix create_node function #393

merged 4 commits into from
Feb 8, 2024

Conversation

perierc
Copy link
Contributor

@perierc perierc commented Feb 7, 2024

What

  • Fixes the create_node function in the backend, which was not creating all necessary properties of an entry node, and was making it impossible to export a project where the user had added a new node.

Fixes bug(s)

@perierc perierc added the backend label Feb 7, 2024
@perierc perierc self-assigned this Feb 7, 2024
@perierc perierc requested a review from a team as a code owner February 7, 2024 16:42
alexgarel
alexgarel approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Reading this, I think for a future refactor, it would be nice, if we separate Node creation logic (using models classes), from database insertion.

@perierc
Copy link
Contributor Author

perierc commented Feb 8, 2024

Thanks !

Reading this, I think for a future refactor, it would be nice, if we separate Node creation logic (using models classes), from database insertion.

You're right. I've decided to refactor now, tell me what you think

@github-actions github-actions bot added the api label Feb 8, 2024
eric-nguyen-cs
eric-nguyen-cs approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@eric-nguyen-cs eric-nguyen-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few straightforward comments but LGTM!

backend/editor/api.py Outdated Show resolved Hide resolved
backend/editor/api.py Outdated Show resolved Hide resolved
backend/editor/api.py Outdated Show resolved Hide resolved
backend/editor/entries.py Show resolved Hide resolved
backend/editor/models/node_models.py Show resolved Hide resolved
backend/editor/controllers/node_controller.py Outdated Show resolved Hide resolved
@perierc perierc merged commit 40a3208 into main Feb 8, 2024
7 checks passed
@perierc perierc deleted the perierc/fix-new-node-creation branch February 8, 2024 14:35
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-nguyen-cs eric-nguyen-cs eric-nguyen-cs approved these changes

@alexgarel alexgarel alexgarel approved these changes

Assignees

@perierc perierc

Labels
api backend frontend
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creation of a new node in frontend makes unparser fail
3 participants
@perierc @alexgarel @eric-nguyen-cs