-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add automatic client SDK generation #405
feat: add automatic client SDK generation #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I approve! I have a question though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really want to put it in the git ?
Why not generate it with fastapi instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Well I found it was easier to implement this way (and it may also facilitate the debugging of the SDK generation)
If you want I can have a look at how to do the FastAPI server but I feel that it may be a bit complex (namely what happens if the server is already running)
What
The goal is in the future to incrementally add
Pydantic
Models as return types to the path functions to serve as output validators and as documentation for the OpenAPI spec.Thus, adding a new API call on the frontend should now involves:
fetch
oraxios
. The API return types should also be imported from the SDK