-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes PLB from openfe #106
Conversation
…35, remove dublicate
Add comments to the target.yaml files
@hannahbaumann , this is amazing work! Thanks for this contribution. I checked the connectivity of the networks and I found out that some of them are disconnected (maybe that's expected?). Specifically:
I took the liberty to do a basic inspection/visualization of the networks and print the "disconnected components" (at least the smallest ones). You can check that at the bottom of this notebook, just in case it helps to know which are the ligands that are disconnected. |
Thank you so much @ijpulidos , this is super helpful! It looks like it's the 5 systems that involve net charge changes. I'll be looking into this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not had time to look at this sorry - Just a quick 2 mins input, I think some of the ligands.yaml entries for the formal charges need changing.
@ijpulidos : Here are the input |
I think Lomap has been modified to be able to generate connected networks when net charge transformations are present. We should probable regenerate these networks here with the latest version of lomap. |
@IAlibay Can you specify which ones? And should we capture this in this PR or make the issue and handle it in another one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the connectivity again and it seems fine. Looks good for me, thanks!
As discussed with @ijpulidos and @jchodera , here the PR from the changes that we made to the PLB.
See below for a list of things that have been changed in this PR.
Benchmarking results obtained using this PR:
Systems that have not been benchmarked yet as they involve net charge changes:
We added tags to the systems in a separate PR, highlighting some challenges of the specific systems
Some additional notes on potential problems that could be fixed in future releases of the PLB: