Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes PLB from openfe #106

Merged
merged 53 commits into from
Jul 29, 2024
Merged

Conversation

hannahbaumann
Copy link
Collaborator

@hannahbaumann hannahbaumann commented Feb 19, 2024

As discussed with @ijpulidos and @jchodera , here the PR from the changes that we made to the PLB.

See below for a list of things that have been changed in this PR.

Benchmarking results obtained using this PR:

Systems that have not been benchmarked yet as they involve net charge changes:

  • cdk8, cmet, eg5, syk, thrombin, tnks2

We added tags to the systems in a separate PR, highlighting some challenges of the specific systems

Some additional notes on potential problems that could be fixed in future releases of the PLB:

hannahbaumann and others added 30 commits November 7, 2023 14:52
@ijpulidos
Copy link
Collaborator

@hannahbaumann , this is amazing work! Thanks for this contribution. I checked the connectivity of the networks and I found out that some of them are disconnected (maybe that's expected?). Specifically:

TARGET: cdk8
NETWORK: 03_edges/lomap_mapper_lomap_network.yml, is connected: False
NETWORK: 03_edges/lomap_mapper_lomap_network_no_element_changes.yml, is connected: False

TARGET: eg5
NETWORK: 03_edges/lomap_mapper_lomap_network.yml, is connected: False
NETWORK: 03_edges/lomap_mapper_lomap_network_no_element_changes.yml, is connected: False

TARGET: syk
NETWORK: 03_edges/lomap_mapper_lomap_network.yml, is connected: False
NETWORK: 03_edges/lomap_mapper_lomap_network_no_element_changes.yml, is connected: False

TARGET: thrombin
NETWORK: 03_edges/lomap_mapper_lomap_network.yml, is connected: False
NETWORK: 03_edges/lomap_mapper_lomap_network_no_element_changes.yml, is connected: False

TARGET: tnks2
NETWORK: 03_edges/lomap_mapper_lomap_network.yml, is connected: False
NETWORK: 03_edges/lomap_mapper_lomap_network_no_element_changes.yml, is connected: False

I took the liberty to do a basic inspection/visualization of the networks and print the "disconnected components" (at least the smallest ones). You can check that at the bottom of this notebook, just in case it helps to know which are the ligands that are disconnected.

@hannahbaumann
Copy link
Collaborator Author

Thank you so much @ijpulidos , this is super helpful! It looks like it's the 5 systems that involve net charge changes. I'll be looking into this!

Copy link
Collaborator

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not had time to look at this sorry - Just a quick 2 mins input, I think some of the ligands.yaml entries for the formal charges need changing.

@hannahbaumann
Copy link
Collaborator Author

@ijpulidos : Here are the input .graphml files for systems MCL1, TYK2, p38, cdk2, hif2a:
ligand_network_mcl1.graphml.zip
ligand_network_tyk2.graphml.zip
ligand_network_p38.graphml.zip
ligand_network_cdk2.graphml.zip
ligand_network_hif2a.graphml.zip

@ijpulidos
Copy link
Collaborator

I think Lomap has been modified to be able to generate connected networks when net charge transformations are present. We should probable regenerate these networks here with the latest version of lomap.

@ijpulidos ijpulidos self-requested a review July 8, 2024 18:34
@ijpulidos
Copy link
Collaborator

Not had time to look at this sorry - Just a quick 2 mins input, I think some of the ligands.yaml entries for the formal charges need changing.

@IAlibay Can you specify which ones? And should we capture this in this PR or make the issue and handle it in another one?

Copy link
Collaborator

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the connectivity again and it seems fine. Looks good for me, thanks!

@IAlibay IAlibay mentioned this pull request Jul 25, 2024
@IAlibay IAlibay merged commit fd88824 into openforcefield:main Jul 29, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants