Add theme support for edxapp's LMS #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up of the hawthorn upgrade (see c52ed36), loading an SQL dump is no longer required, hence this legacy variable should be removed.
This work adapts @sampaccoud's work on #105 to add customizable themes for the LMS. We've added an example for patient0/development with a public theme cooked by the Racoongang team.
jmaupetit
force-pushed
the
add-edxapp-theme-support
branch
from
a0a72e2 to
e273e69
Compare
sampaccoud
approved these changes
Sep 4, 2018
|
Superb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
disclaimer this PR is a replacement for #105
Proposal
patient0-developmentCloses #105