Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update js #2681

Merged
merged 21 commits into from
Jan 29, 2025
Merged

update js #2681

merged 21 commits into from
Jan 29, 2025

Conversation

kernicPanel
Copy link
Member

@kernicPanel kernicPanel commented Jan 15, 2025

Purpose

Update js dependencies.
#2662 is old and must be manually replaced.

@kernicPanel kernicPanel force-pushed the kernicpanel/renovate/js-dependencies branch 15 times, most recently from 24556e7 to 9c2bb02 Compare January 21, 2025 13:00
@kernicPanel kernicPanel force-pushed the kernicpanel/renovate/js-dependencies branch 2 times, most recently from 4727d79 to fbb6070 Compare January 23, 2025 17:01
@kernicPanel kernicPanel force-pushed the kernicpanel/renovate/js-dependencies branch from fbb6070 to 117f5af Compare January 23, 2025 17:05
@kernicPanel kernicPanel force-pushed the kernicpanel/renovate/js-dependencies branch 3 times, most recently from d699c2c to bb615a2 Compare January 23, 2025 17:20
@kernicPanel kernicPanel requested a review from jbpenrath January 23, 2025 17:37
@kernicPanel kernicPanel self-assigned this Jan 23, 2025
@@ -11,7 +11,7 @@
"aws-sdk": "2.1692.0",
"clamscan": "2.4.0",
"he": "1.2.0",
"jimp": "1.6.0",
"jimp": "0.22.12",
Copy link
Member

@jbpenrath jbpenrath Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I pinned a dependency, I often use '<' to continue to install patches.

Suggested change
"jimp": "0.22.12",
"jimp": ">=0.22.12 <1",

@@ -75,7 +75,7 @@
"react-router-dom": "6.22.2",
"styled-components": "5.3.11",
"typescript": "5.7.2",
"zustand": "4.5.2"
"zustand": "4.5.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Suggested change
"zustand": "4.5.5"
"zustand": ">=4.5.5 <5"

@@ -72,7 +71,7 @@
"react": "18.2.0",
"react-dom": "18.2.0",
"react-intl": "7.1.0",
"react-router-dom": "6.22.2",
"react-router-dom": "6.28.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Suggested change
"react-router-dom": "6.28.2",
"react-router-dom": ">=6.28.2 <7",

screen,
render as testingLibraryRender,
} from '@testing-library/react';
import { Grommet, ResponsiveContext, ThemeType } from 'grommet';
import MatchMediaMock from 'jest-matchmedia-mock';
import { BreadCrumbsProvider, GlobalStyles, Nullable, theme } from 'lib-common';
import React, { CSSProperties, ComponentProps, ReactElement } from 'react';
import { act } from 'react-dom/test-utils';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this method is deprecated in favor of react/test-utils.
https://react.dev/warnings/react-dom-test-utils

But I don't understand why you cannot continue to use act from testing-library/react ?

@kernicPanel kernicPanel requested a review from jbpenrath January 28, 2025 17:35
jimp v1 requires node 20 to run.
We postpone this update for now.
Update sentry/browser dependency and code.
Remove useless fetch-mock types.
Something is broken with our import config and fetch-mock v10
Update typescript and code.
Add @typescript-eslint/typescript-estree.
Update grommet and code.
Zustand v5 introduce breaking changes.
We are updating to last v4.
@kernicPanel kernicPanel force-pushed the kernicpanel/renovate/js-dependencies branch from 0224bb0 to b0ca449 Compare January 28, 2025 17:48
Update react-router to last v6 and pin it.
Remove @types/react-router.
Pin mermaid types to 9.1.0.
Update dompurify and code.
Pin eslint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser
Update testing-library and code.
Update react to 18.3.1 and code.
Update react 19 and code.
E2e tests needed some fix, due do one of recent dependency update.
@kernicPanel kernicPanel force-pushed the kernicpanel/renovate/js-dependencies branch from 13cbfa6 to f3ee70b Compare January 29, 2025 07:08
@kernicPanel kernicPanel merged commit e08df05 into master Jan 29, 2025
32 of 33 checks passed
@kernicPanel kernicPanel deleted the kernicpanel/renovate/js-dependencies branch January 29, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants