-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Teams Endpoints #1031
base: master
Are you sure you want to change the base?
Conversation
Planned Tasks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! There are a few things cleanup to be done before you continue working on these. Would you mind to address the feedback first, so it will be much easier for review.
In short:
- don't leave random commented code here and there
- no need to comment obvious things
- please install
pre-commit
- please rebase on master
- remove
docker-compose.override.local.yml
changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment:
- there are still archeological treasures from the initial development, please make sure you remove these and push them
- merge all the tests in one
test_teams.py
file - the views can be a bit more
django-rest-framework
-like (DRF) , e.g. you can useRetrieveUpdateDestroyAPIView
or similar for the views baseclasses for "teams" and "team members". This will greatly reduce your codebase and simplify maintainence.
- cleanup the initial comments in this PR and push all the changes.
- rebase to the latest master and push
- run
pre-commit
and push - address most of the requests not related the the views.py or tests
- try to automate views behavior with DRF
- continue with tests
New endpoints have been created for managing both teams and member under organization for CRUD actions