Sending raw body to sentry

[why-not-try-calmer]

A few clarifications and observations:

• Actually this is fine => DownloadPushDeleteFileView.post() does not trigger the parse() method of its declared parser_class (MultiPartParser), because I did subclass this parser class in a previous version of this PR, and my override of parse() never triggered in my tests
• This is done => room for improvement: ensure that the intended parse() function is called, so that we can debug more from that context; this might open the door to reading the request.body only for requests that fail, and not all of them as is the case here.

[duke-nyuki]

Task linked: QF-2704 Debug EmptyContentError: Empty content when uploading files (log raw request from Django)

[why-not-try-calmer]

Raw body:
request_id_file_name_rawbody.txt

More samples on Sentry.

Alternatively, as I said in the Daily (perhaps also of interest for you @m-kuhn since you said you really, really would like to see a full request), a request object could cloned-then-serialized with:

import shutil
import copy

cloned_request: wsgi.WSGIRequest = copy.deepcopy(request)
output_stream = io.BytesIO()
shutil.copyfileobj(cloned_request, output_stream)

[suricactus]

Looks good, two small comments and one idea we communicate in the chat.

[suricactus]

Not sure why the changes replaced in 989c7b6 were existing?

[suricactus]

@why-not-try-calmer this seems does not work with real life example outside the test case. At least in my local experiments, I have tried to upload a file and enter the if sending to Sentry as in files_views.py.

What I have observed is that the middleware and the views are having different request objects, one intsance of WSGIRequest and the other one is DRFRequest. Therefore getattr(request, 'body_stream', None) always returns None outside the test scenario. I guess I am missing something or I might have broken something with my changes.

Can you please post your steps of testing with real world file upload? Thanks!

[suricactus]

@why-not-try-calmer all works fine, seems it was a misconfiguration from my side. Allowed myself a final change before merging.

Thanks for sorting this out!

[why-not-try-calmer]

@why-not-try-calmer all works fine, seems it was a misconfiguration from my side. Allowed myself a final change before merging.

Thanks for sorting this out!

Looks ready to merge! (I would approve but I am the PR author so I cannot)