Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup @deprecated code that affect only tests #767

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Cleanup @deprecated code that affect only tests #767

merged 6 commits into from
Aug 17, 2023

Conversation

faebebin
Copy link
Member

@faebebin faebebin commented Aug 15, 2023 •
edited
Loading

Remove @deprecated objects that are referenced only in tests or nowhere.

Should remove some noise / unused code.

@faebebin faebebin added minor Requires minor version change chore Maintanance, clean-up and other not fancy improvements. refactor Rewrite code to achieve the goal in a better way. labels Aug 15, 2023
@faebebin faebebin changed the title [WIP] Cleanup @deprecated that affect only tests Cleanup @deprecated that affect only tests Aug 16, 2023
@faebebin faebebin marked this pull request as ready for review August 16, 2023 05:33
@faebebin faebebin changed the title Cleanup @deprecated that affect only tests Cleanup @deprecated code that affect only tests Aug 16, 2023
why-not-try-calmer
why-not-try-calmer suggested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@why-not-try-calmer why-not-try-calmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using a bytes_to_mb function instead of writing * 1000 * 1000 to make refactoring in the future a bit easier.

@faebebin
Merge pull request #768 from opengisch/QF-3047_fix_email_notification…
712be9d 
…s_link

Fix settings link in notifications email
@faebebin faebebin merged commit 86065d5 into master Aug 17, 2023
12 checks passed
@faebebin faebebin deleted the cleanup-deprecated-code branch August 17, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@why-not-try-calmer why-not-try-calmer why-not-try-calmer approved these changes

@suricactus suricactus Awaiting requested review from suricactus

Assignees
No one assigned
Labels
chore Maintanance, clean-up and other not fancy improvements. minor Requires minor version change refactor Rewrite code to achieve the goal in a better way.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faebebin @why-not-try-calmer