Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prevent DeadLocks on apply_job #772

Closed
wants to merge 1 commit into from
Closed

[WIP] Prevent DeadLocks on apply_job #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions docker-app/qfieldcloud/core/utils2/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ def apply_deltas(
# 2. Check if there are any pending deltas.
# We need to call .select_for_update() to make sure there would not be a concurrent
# request that will try to apply these deltas.
pending_deltas = models.Delta.objects.select_for_update().filter(
project=project,
last_status=models.Delta.Status.PENDING,
pending_deltas = (
models.Delta.objects.select_for_update()
.filter(
project=project,
last_status=models.Delta.Status.PENDING,
)
.order_by("created_at")
)

# 2.1. Filter only the deltas of interest.
Expand Down
Loading