Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints in worker_wrapper #778

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Type hints in worker_wrapper #778

merged 2 commits into from
Aug 25, 2023

Conversation

why-not-try-calmer
Copy link
Contributor

While working on a recent task I cleaned up some type hints.

@why-not-try-calmer why-not-try-calmer added the chore Maintanance, clean-up and other not fancy improvements. label Aug 24, 2023
@why-not-try-calmer why-not-try-calmer force-pushed the wrapper-type-hints branch 2 times, most recently from ed42e6d to 4ca711c Compare August 24, 2023 09:50
suricactus
suricactus approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do you think this is ready to be mypy-ied? Would be nice to add more and more files to be automatically checked.

@suricactus suricactus merged commit 5885c49 into master Aug 25, 2023
11 of 12 checks passed
@suricactus suricactus deleted the wrapper-type-hints branch August 25, 2023 08:57
@why-not-try-calmer
Copy link
Contributor Author

Thanks!

Do you think this is ready to be mypy-ied? Would be nice to add more and more files to be automatically checked.

I think it is, or is close to being mypy-compliant. Happy to adjust any rough edge if mypy complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
chore Maintanance, clean-up and other not fancy improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@why-not-try-calmer @suricactus