Removed redis as a dependency #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the end of the day it was never actually used and only brings noise when QFC is deployed.
why-not-try-calmer
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Nice cleanup, I found only 1 occurrence of redis in public but it's rather inocuous (docstring).
Looking forward to the next release providing the updated image, as I kinda need it to tweak an on-premise version. In the meantime I have added an empty entrypoint to Compose but that's inelegant.
why-not-try-calmer
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end of the day it was never actually used and only brings noise when QFC is deployed.