Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure subscription created_by Person and overwrite createsuperuser #797

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Ensure subscription created_by Person and overwrite createsuperuser #797

merged 6 commits into from
Oct 4, 2023

Conversation

faebebin
Copy link
Member

@faebebin faebebin commented Sep 27, 2023 •
edited
Loading

#QF3203

https://app.clickup.com/t/2192114/QF-3203

Tested locally to create an organization and worked.

@faebebin faebebin requested a review from suricactus September 27, 2023 22:20
@faebebin faebebin changed the title Ensure create_subscription created_by Person and overwrite createsupe… Ensure subscription created_by Person and overwrite createsuperuser Sep 27, 2023
@duke-nyuki
Copy link
Collaborator

Task linked: QF-3203 Fix field remaining_trial_organizations does not exist

@faebebin faebebin added bug Something isn't working patch Requires patch version change labels Sep 29, 2023
@suricactus
Copy link
Collaborator

I think the createuser command is still used by the k8s setup, we should not remove it, but fix it.

@faebebin
Copy link
Member Author

faebebin commented Oct 4, 2023

Ok, will do asap

@faebebin faebebin requested a review from suricactus October 4, 2023 12:46
@faebebin
Copy link
Member Author

faebebin commented Oct 4, 2023

Both createuser.py and createsuperuser.py create a Person instance now.

IMO we should nevertheless get rid of the createuser.py . Create followup task?

@suricactus suricactus mentioned this pull request Oct 4, 2023
Closed
suricactus
suricactus approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would prefer to have a single command too. I think it was mostly password related thing, it was robert197 who added this in the first place.

Thanks for the fixes!

@suricactus suricactus merged commit 45e350d into master Oct 4, 2023
@suricactus suricactus deleted the create_subscription_by_person_for_superuser branch October 4, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working patch Requires patch version change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faebebin @duke-nyuki @suricactus