-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenAPI and Swagger URLs and CORS #802
Conversation
Are you talking about https://github.com/opengisch/qfieldcloud/pull/722/files#diff-53c9c2dd0d12c371d3267292e547885a0189ce67b77ec67b3f6b590f140d959a? No, no reason I would have taken seriously in light of any evidence that this was breaking something. I think this PR benefitted from discussions plus a coworking session so I don't think I was trying to be original there. |
@@ -42,14 +42,19 @@ | |||
name="index", | |||
), | |||
path( | |||
"schema/", | |||
"swagger.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not considered a good practice to use file extensions in urls, for the sake of not being hostage of an extension. But I am no expert in these conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it depends. For the sake of backwards compatibility, it should have the extension for now.
Also I should point out that the url used in the documentation does point to a valid endpoint, any overlook notwithstanding. So isn't it simply the embedded JS being off? |
I would not prefer not to change it now. |
Since the schema endpoint has been changed, we broke the integration on https://docs.qfield.org/reference/qfieldcloud/api/ . I overlooked the endpoint renaming.
@why-not-try-calmer was there any reason you rename endpoints?