[hdpowerview] Fix tilt support for vertical slats #13169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <[email protected]>
andrewfg
added
bug
|
For testing, the JAR file is here... |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/hd-powerview-binding-issue-openhab-3-3-0/136921/41 |
jlaur
reviewed
Jul 24, 2022
...c/main/java/org/openhab/binding/hdpowerview/internal/database/ShadeCapabilitiesDatabase.java
Show resolved
Hide resolved
jlaur
approved these changes
Jul 24, 2022
|
@andrewfg - consider changing PR title to something like "Fix tilt support for vertical slats" so it will be more understandable for users when reading release notes. |
Yes, I think we should do that.
Ok. Done. |
andrewfg
changed the title
andrewfg
removed
the
additional testing preferred
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Jul 25, 2022
…#13169) Signed-off-by: Andrew Fiddian-Green <[email protected]>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…#13169) Signed-off-by: Andrew Fiddian-Green <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…#13169) Signed-off-by: Andrew Fiddian-Green <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…#13169) Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…#13169) Signed-off-by: Andrew Fiddian-Green <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…#13169) Signed-off-by: Andrew Fiddian-Green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As reported on the forum here one user has reported that his type 55 and type 56 shades do not support vane tilt controls.
As discussed here it seems that some instances of these shades are incorrectly reporting capabilities:4 when they actually support capabilities:3 functionality
Solution
This PR applies a
capabilitiesOverride()to those shade types.Signed-off-by: Andrew Fiddian-Green [email protected]