Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews from #3503 #3507

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Reviews from #3503 #3507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions mobile/src/main/java/org/openhab/habdroid/background/ItemsControlsProviderService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,12 @@ class ItemsControlsProviderService : ControlsProviderService() {
}
val topic = event.getString("topic")
val topicPath = topic.split('/')
/* Possible formats:
* - openhab/items/<item>/statechanged
* - openhab/items/<group item>/<item>/statechanged
* When an update for a group is sent, there's also one for the individual item.
* Therefore always take the element on index two.
*/
if (topicPath.size !in intArrayOf(4, 5)) {
// Possible formats:
// - openhab/items/<item>/statechanged
// - openhab/items/<group item>/<item>/statechanged
// When an update for a group is sent, there's also one for the individual item.
// Therefore always take the element on index two.
if (topicPath.size !in 4..5) {
throw JSONException("Unexpected topic path $topic")
}
val item = allItems[topicPath[2]]
Expand Down