Expose mobile api ids in API (#457)

Signed-off-by: Dan Cunningham <[email protected]>
openhab · May 26, 2024 · 2076336 · 2076336
1 parent 22526ee
commit 2076336
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/routes/api.js b/routes/api.js
@@ -59,9 +59,16 @@ exports.hidenotification = function (req, res) {
         return res.status(200).json({});
     });
 }
-
+ 
 exports.proxyurlget = function (req, res) {
     res.status(200).json({
         'url': system.getProxyURL()
     });
 };
+
+exports.appids = function (req, res) {
+    res.status(200).json({
+        'ios': system.getAppleId(),
+        'android': system.getAndroidId()
+    });
+}; 
diff --git a/routes/index.js b/routes/index.js
@@ -221,10 +221,11 @@ Routes.prototype.setupProxyRoutes = function (app) {
 
 Routes.prototype.setupAppRoutes = function (app) {
     // myOH API for mobile apps
-    app.all('/api/v1/notifications', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.notificationsget);
-    app.all('/api/v1/hidenotification/:id', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.hidenotification);
-    app.all('/api/v1/settings/notifications', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.notificationssettingsget);
-    app.all('/api/v1/proxyurl', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.proxyurlget);
+    app.get('/api/v1/notifications', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.notificationsget);
+    app.get('/api/v1/hidenotification/:id', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.hidenotification);
+    app.get('/api/v1/settings/notifications', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.notificationssettingsget);
+    app.get('/api/v1/proxyurl', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.proxyurlget);
+    app.get('/api/v1/appids', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, api_routes.appids);
 
     // Android app registration (FCM)
     app.all('/addAndroidRegistration*', this.ensureRestAuthenticated, this.setOpenhab, this.preassembleBody, fcmRegistrationService.registerAndroid);

diff --git a/system/index.js b/system/index.js
@@ -238,12 +238,16 @@ System.prototype.isIFTTTEnabled = function() {
  * @return {string}
  */
 System.prototype.getAppleLink = function() {
+    return 'https://itunes.apple.com/app/id' + this.getAppleId();
+};
+
+System.prototype.getAppleId = function() {
     let appleId = '492054521';
     try {
         appleId = this.getConfig(['apps', 'appleId']);
     } catch (err) {}
 
-    return 'https://itunes.apple.com/app/id' + appleId;
+    return  appleId;
 };
 
 /**
@@ -252,12 +256,16 @@ System.prototype.getAppleLink = function() {
  * @return {string}
  */
 System.prototype.getAndroidLink = function () {
+    return 'https://play.google.com/store/apps/details?id=' + this.getAndroidId();
+};
+
+System.prototype.getAndroidId = function () {
     let playStoreId = 'org.openhab.habdroid';
     try {
         playStoreId = this.getConfig(['apps', 'playStoreId']);
     } catch (err) {}
 
-    return 'https://play.google.com/store/apps/details?id=' + playStoreId;
+    return playStoreId;
 };
 
 /**