Exclude org.osgi.service.prefs to fix build #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone added a dependency on a non-existing artifact in the new Equinox release and now many builds are broken because Xtext defines a version range for Equinox 😞, see: * eclipse-equinox/equinox.bundles#54 * eclipse-xtext/xtext#2077 Signed-off-by: Wouter Born <[email protected]>
|
Did you check if this is still needed after they deployed a new version an hour ago? |
|
Yes see this recent build: https://ci.openhab.org/job/openHAB-Core/1014/ It will probably try to keep resolving it until it is excluded in Xtext. |
|
It still resolves 3.10.0, while the new artifact has 3.10.1, maybe this issue only persists until the maven cache expires and 3.10.1 is included? But I'm fine with this solution, too. We can revert it later if we run into issues. |
J-N-K
approved these changes
Jun 15, 2022
J-N-K
added
critical
external bug
|
It seems we can revert the change in the near future: https://issues.sonatype.org/browse/OSSRH-81766 |
J-N-K
pushed a commit
that referenced
this pull request
Jun 17, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Someone added a dependency on a non-existing artifact in the new Equinox release and now many builds are broken because Xtext defines a version range for Equinox 😞, see: * eclipse-equinox/equinox.bundles#54 * eclipse-xtext/xtext#2077 Signed-off-by: Wouter Born <[email protected]> GitOrigin-RevId: af0566a
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
…penhab#3005) This reverts commit af0566a. GitOrigin-RevId: 2b4e5af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone added a dependency on a non-existing artifact in the new Equinox release and now many builds are broken because Xtext defines a version range for Equinox 😞, see:
org.osgi.service.prefsdependency in org.eclipse.equinox.preferences-3.10.0 eclipse-equinox/equinox.bundles#54