Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: replace config with the parameter to pass #1959

Closed
luhaoling opened this issue Feb 27, 2024 · 2 comments
Closed

Bug: replace config with the parameter to pass #1959

luhaoling opened this issue Feb 27, 2024 · 2 comments
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@luhaoling
Copy link
Contributor

What happened?

There are many places inside this project where global variables are used directly. This increases the coupling of the code and functions with the same functionality cannot be reused.

What did you expect to happen?

Replace config with the parameter to pass, improve code reusability.

How can we reproduce it (as minimally and precisely as possible)?

none

Anything else we need to know?

No response

version

```console $ {name} version # paste output here ```

Cloud provider

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Install tools

@luhaoling luhaoling added the bug Categorizes issue or PR as related to a bug. label Feb 27, 2024
@kubbot
Copy link
Contributor

kubbot commented Apr 27, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@kubbot
Copy link
Contributor

kubbot commented May 6, 2024

This issue was closed because it has been stalled for 7 days with no activity.

@kubbot kubbot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants