Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace config with the parameter to pass #1960

Closed
wants to merge 15 commits into from

Conversation

luhaoling
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1959

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2024
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 4.49%. Comparing base (c754ec6) to head (59717e3).
Report is 18 commits behind head on main.

Files Patch % Lines
internal/tools/msg.go 0.00% 17 Missing ⚠️
internal/msggateway/n_ws_server.go 0.00% 11 Missing ⚠️
internal/msggateway/hub_server.go 0.00% 10 Missing ⚠️
internal/msggateway/callback.go 0.00% 9 Missing ⚠️
internal/msggateway/init.go 0.00% 8 Missing ⚠️
internal/tools/cron_task.go 20.00% 8 Missing ⚠️
pkg/common/config/config.go 0.00% 6 Missing ⚠️
pkg/common/startrpc/start.go 37.50% 5 Missing ⚠️
internal/msggateway/message_handler.go 0.00% 3 Missing ⚠️
pkg/common/config/parse.go 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1960      +/-   ##
========================================
- Coverage   5.32%   4.49%   -0.83%     
========================================
  Files         43      34       -9     
  Lines       3852    2135    -1717     
========================================
- Hits         205      96     -109     
+ Misses      3634    2029    -1605     
+ Partials      13      10       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: replace config with the parameter to pass
2 participants