-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: notify nodes concurrently on register #1327
Merged
openimbot
merged 1 commit into
openimsdk:main
from
rfyiamcool:perf/concurrent_notify_node_on_register
Nov 13, 2023
Merged
perf: notify nodes concurrently on register #1327
openimbot
merged 1 commit into
openimsdk:main
from
rfyiamcool:perf/concurrent_notify_node_on_register
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfyiamcool
requested review from
skiffer-git,
FGadvancer,
a team,
cubxxw,
Bloomingg and
withchao
as code owners
November 2, 2023 09:10
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 2, 2023
Apply Sweep Rules to your PR?
|
Codecov Report
@@ Coverage Diff @@
## main #1327 +/- ##
========================================
- Coverage 4.30% 4.29% -0.02%
========================================
Files 45 45
Lines 3809 3819 +10
========================================
Hits 164 164
- Misses 3634 3644 +10
Partials 11 11
|
cubxxw
previously approved these changes
Nov 3, 2023
@rfyiamcool I kindly request your assistance in resolving a conflict. |
auto-merge was automatically disabled
November 13, 2023 03:34
Head branch was pushed to by a user without write access
rfyiamcool
force-pushed
the
perf/concurrent_notify_node_on_register
branch
from
November 13, 2023 03:34
8c05cb4
to
5b831d3
Compare
pull-request-size
bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 13, 2023
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
Signed-off-by: rfyiamcool <[email protected]>
rfyiamcool
force-pushed
the
perf/concurrent_notify_node_on_register
branch
from
November 13, 2023 05:00
5b831d3
to
a630f42
Compare
pull-request-size
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Nov 13, 2023
cubxxw
approved these changes
Nov 13, 2023
openimbot
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
notify client info to nodes concurrently on register.
some code
import package