Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding monitoring functionality to binary deployment scripts #1386

Closed
wants to merge 91 commits into from

Conversation

xuexihuang
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1385

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

lin.huang and others added 30 commits September 24, 2023 06:17
Copy link
Contributor

sweep-ai bot commented Nov 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7502b4a) 4.35% compared to head (7994ba1) 4.35%.

❗ Current head 7994ba1 differs from pull request most recent head 0ff1c30. Consider uploading reports for the commit 0ff1c30 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1386   +/-   ##
=====================================
  Coverage   4.35%   4.35%           
=====================================
  Files         49      49           
  Lines       4114    4114           
=====================================
  Hits         179     179           
  Misses      3923    3923           
  Partials      12      12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw closed this Nov 14, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Adding monitoring functionality to binary deployment scripts
3 participants