Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update nick name field for get_user #1786

Merged
merged 196 commits into from
Jan 19, 2024

Conversation

AndrewZuo01
Copy link
Contributor

@AndrewZuo01 AndrewZuo01 commented Jan 19, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1787

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a5129b) 5.10% compared to head (4305d50) 5.10%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1786   +/-   ##
=====================================
  Coverage   5.10%   5.10%           
=====================================
  Files         42      42           
  Lines       3797    3797           
=====================================
  Hits         194     194           
  Misses      3592    3592           
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw added this pull request to the merge queue Jan 19, 2024
Merged via the queue into openimsdk:main with commit 19f5c94 Jan 19, 2024
25 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Jan 19, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: get_users use username as field
7 participants