-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance Script Details and Add MacOS Compatibility with Documentation Updates #1794
Conversation
OpenIM TestOpenIM API TestCommand Output for OpenIM API Test
OpenIM E2E TestCommand Output for OpenIM E2E Test
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1794 +/- ##
========================================
+ Coverage 5.10% 5.28% +0.17%
========================================
Files 42 43 +1
Lines 3797 3821 +24
========================================
+ Hits 194 202 +8
- Misses 3592 3606 +14
- Partials 11 13 +2 ☔ View full report in Codecov by Sentry. |
Fixing PR: track the progress here.I'm currently fixing this PR to address the following: [Sweep GHA Fix] The GitHub Actions run failed with the following error logs:
An error has occurred: Message is too long, max tokens is -11936 (tracking ID: 4d0910386a) |
🔍 What type of PR is this?
👀 What this PR does / why we need it:
This Pull Request introduces several enhancements to the existing scripts, adding support for MacOS deployment, and updating the documentation to reflect these changes. The key updates include:
Script Optimization: Improved the overall structure and readability of the scripts, making them more efficient and easier to maintain.
MacOS Compatibility: Extended support to MacOS by adding conditional statements to handle differences in command-line tools, especially the
ps
command, ensuring seamless functionality across both Linux and MacOS platforms.Documentation Improvements: Updated the documentation to include instructions and notes on MacOS compatibility, providing clear guidance for users deploying on MacOS.
These enhancements not only make the scripts more versatile and user-friendly but also ensure a wider range of compatibility, catering to a broader audience. This PR is a step forward in improving the usability and accessibility of our project, making it more inclusive for users across different operating systems.
I have thoroughly tested these changes on both Linux and MacOS environments to ensure reliability and consistency in performance.
🅰 Which issue(s) this PR fixes:
Fixes #1793
📝 Special notes for your reviewer:
🎯 Describe how to verify it
Could you please assist with the validation of deployment through CICD and on a local Mac computer?
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: