Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize server code #1931

Merged
merged 16 commits into from
Feb 20, 2024
Merged

feat: optimize server code #1931

merged 16 commits into from
Feb 20, 2024

Conversation

withchao
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1930

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (c754ec6) 5.32% compared to head (cf62471) 4.73%.
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/common/db/cache/msg.go 0.00% 39 Missing ⚠️
internal/msggateway/compressor.go 0.00% 9 Missing ⚠️
pkg/common/http/http_client.go 0.00% 9 Missing ⚠️
internal/msggateway/client.go 0.00% 7 Missing ⚠️
pkg/common/db/cache/meta_cache.go 0.00% 2 Missing ⚠️
internal/msggateway/encoder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1931      +/-   ##
========================================
- Coverage   5.32%   4.73%   -0.60%     
========================================
  Files         43      43              
  Lines       3852    3318     -534     
========================================
- Hits         205     157      -48     
+ Misses      3634    3148     -486     
  Partials      13      13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw enabled auto-merge February 20, 2024 09:21
@cubxxw cubxxw added this pull request to the merge queue Feb 20, 2024
Merged via the queue into openimsdk:main with commit d5d2803 Feb 20, 2024
26 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Feb 20, 2024
@github-actions github-actions bot added this to the v3.1 milestone Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: optimize server code
3 participants