Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization: change the configuration file from being read globally … #1935

Merged
merged 65 commits into from
Mar 5, 2024

Conversation

FGadvancer
Copy link
Member

…to being read independently.


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1930

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 16.39344% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 4.63%. Comparing base (c754ec6) to head (04dae35).
Report is 36 commits behind head on main.

Files Patch % Lines
internal/msggateway/n_ws_server.go 0.00% 11 Missing ⚠️
internal/msggateway/hub_server.go 0.00% 10 Missing ⚠️
internal/msggateway/callback.go 0.00% 9 Missing ⚠️
internal/msggateway/init.go 0.00% 8 Missing ⚠️
pkg/common/startrpc/start.go 33.33% 6 Missing ⚠️
internal/msggateway/message_handler.go 0.00% 3 Missing ⚠️
pkg/common/prommetrics/prommetrics.go 40.00% 3 Missing ⚠️
pkg/common/discoveryregister/discoveryregister.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1935      +/-   ##
========================================
- Coverage   5.32%   4.63%   -0.70%     
========================================
  Files         43      28      -15     
  Lines       3852    1814    -2038     
========================================
- Hits         205      84     -121     
+ Misses      3634    1720    -1914     
+ Partials      13      10       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added this to the v3.1 milestone Mar 5, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: optimize server code
5 participants