Fix Push2User webhookBeforeOfflinePush #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storyn26383
requested review from
Bloomingg,
FGadvancer,
skiffer-git and
withchao
as code owners
pull-request-size
bot
added
the
size/S
|
I have read the CLA Document and I hereby sign the CLA |
OpenIM-Robot
added a commit
to OpenIM-Robot/cla
that referenced
this pull request
Nov 19, 2024
FGadvancer
approved these changes
Nov 20, 2024
mo3et
approved these changes
Nov 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 5th argument of webhookBeforeOfflinePush should not be nil, this PR will fix that problem.