Merge pull request #1 from FGadvancer/main

feat: change close function to interface Adapting for Kubernetes
openimsdk · Oct 26, 2023 · ad22819 · ad22819
2 parents e57fda1 + 56ec64c
commit ad22819
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/discoveryregistry/discovery_register.go b/discoveryregistry/discovery_register.go
@@ -37,4 +37,5 @@ type SvcDiscoveryRegistry interface {
 	CreateRpcRootNodes(serviceNames []string) error
 	RegisterConf2Registry(key string, conf []byte) error
 	GetConfFromRegistry(key string) ([]byte, error)
+	Close()
 }
diff --git a/discoveryregistry/zookeeper/zk.go b/discoveryregistry/zookeeper/zk.go
@@ -137,7 +137,7 @@ func NewClient(zkServers []string, zkRoot string, options ...ZkOption) (*ZkClien
 	client.eventChan = eventChan
 	client.conn = conn
 	if err := client.ensureRoot(); err != nil {
-		client.CloseZK()
+		client.Close()
 		return nil, err
 	}
 	resolver.Register(client)
@@ -147,7 +147,7 @@ func NewClient(zkServers []string, zkRoot string, options ...ZkOption) (*ZkClien
 	return client, nil
 }
 
-func (s *ZkClient) CloseZK() {
+func (s *ZkClient) Close() {
 	s.logger.Printf("close zk called")
 	s.cancel()
 	s.ticker.Stop()