Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Cleanup SoftSynthesizer.getDefaultSoundbank #22296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Nov 21, 2024

After #22186 there is quite ugly code, which creates lambda and executes it immediately.
Refactoring it into a separate method makes code more readable and easier to understand.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22296/head:pull/22296
$ git checkout pull/22296

Update a local copy of the PR:
$ git checkout pull/22296
$ git pull https://git.openjdk.org/jdk.git pull/22296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22296

View PR using the GUI difftool:
$ git pr show -t 22296

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22296.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2024

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant