8344833: CTW: Make failing on zero classes optional #22320
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CTW, zero classes in provided jar is now a failure.
This creates noisy and blocking false positives in fuzzy/mass scale runs, where we use jar archives from random sources, unchecked or randomly generated, etc.
This PR makes this behaviour controllable. Default reaction is a failure, like before.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22320/head:pull/22320
$ git checkout pull/22320
Update a local copy of the PR:
$ git checkout pull/22320
$ git pull https://git.openjdk.org/jdk.git pull/22320/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22320
View PR using the GUI difftool:
$ git pr show -t 22320
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22320.diff
Using Webrev
Link to Webrev Comment